This is not GitHub.com

Like what you see? Install OctoLinker now!

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated code "getUrl" (tests) #436

Merged
merged 1 commit into from May 16, 2020
Merged

Conversation

@joeyrogues
Copy link
Contributor

joeyrogues commented May 16, 2020

Very small improvement.

Good to know: ava consider files starting with a _ to be helper files.
Therefore, the _test-utils.js file is not "asserted".

Interesting: I decided to use a closure (dependency injection) because micro requires the NODE_ENV to be set before import.

@timneutkens timneutkens merged commit c85f41d into vercel:master May 16, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.